Re: [PATCH v5 1/2] io: Add support for MSG_PEEK for socket channel

[Peter Xu]

On Tue, Nov 29, 2022 at 04:24:58PM +0530, manish.mishra wrote:
> 
> On 23/11/22 11:34 pm, Peter Xu wrote:
> > On Wed, Nov 23, 2022 at 05:27:34PM +0000, manish.mishra wrote:
> > > MSG_PEEK reads from the peek of channel, The data is treated as
> > > unread and the next read shall still return this data. This
> > > support is currently added only for socket class. Extra parameter
> > > 'flags' is added to io_readv calls to pass extra read flags like
> > > MSG_PEEK.
> > > 
> > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.co
> > > Suggested-by: Daniel P. Berrangé <berrange@redhat.com
> > > Signed-off-by: manish.mishra <manish.mishra@nutanix.com>
> > Reviewed-by: Peter Xu <peterx@redhat.com>
> > 
> Hi Peter, Daniel
> 
> Just wanted to check if both patches in this series are approved or i
> need to update few more things. Also Peter, for your Review-by to be
> included do i need to send another patch version or it will be taken up
> whoever will be merging it?

No need to resend it for now.

https://wiki.qemu.org/Planning/7.2

Today should tag rc3, maybe it's too late for such a change to go into this
release.  It's not a regression of 7.2 so may not be justified either.

Maybe it'll need to wait until the next dev cycle opens.

Thanks,

-- 
Peter Xu