qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/10] error: Move ERRP_GUARD() to the beginning of the funct


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 03/10] error: Move ERRP_GUARD() to the beginning of the function
Date: Mon, 21 Nov 2022 12:19:52 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 21/11/22 09:50, Markus Armbruster wrote:
include/qapi/error.h advises to put ERRP_GUARD() right at the
beginning of the function, because only then can it guard the whole
function.  Clean up the few spots disregarding the advice.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
  hw/arm/armsse.c        | 3 +--
  hw/core/machine.c      | 3 +--
  hw/virtio/vhost-vdpa.c | 2 +-
  iothread.c             | 2 +-
  monitor/qmp-cmds.c     | 4 ++--
  5 files changed, 6 insertions(+), 8 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]