qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/10] qapi: Use returned bool to check for failure (again)


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 09/10] qapi: Use returned bool to check for failure (again)
Date: Mon, 21 Nov 2022 12:19:06 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 21/11/22 09:50, Markus Armbruster wrote:
Commit 012d4c96e2 changed the visitor functions taking Error ** to
return bool instead of void, and the commits following it used the new
return value to simplify error checking.  Since then a few more uses
in need of the same treatment crept in.  Do that.  All pretty
mechanical except for

* balloon_stats_get_all()

   This is basically the same transformation commit 012d4c96e2 applied
   to the virtual walk example in include/qapi/visitor.h.

* set_max_queue_size()

   Additionally replace "goto end of function" by return.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
  accel/kvm/kvm-all.c              |  5 +----
  hw/core/qdev-properties-system.c |  5 +----
  hw/i386/pc.c                     |  5 +----
  hw/virtio/virtio-balloon.c       | 20 +++++++++-----------
  hw/virtio/virtio-mem.c           | 10 ++--------
  net/colo-compare.c               | 13 ++++---------
  target/i386/kvm/kvm.c            |  5 +----
  util/thread-context.c            | 10 ++--------
  8 files changed, 21 insertions(+), 52 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]