[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/11] block/blkio: Set BlockDriver::has_variable_length to false
From: |
Kevin Wolf |
Subject: |
[PULL 07/11] block/blkio: Set BlockDriver::has_variable_length to false |
Date: |
Fri, 11 Nov 2022 16:27:40 +0100 |
From: Alberto Faria <afaria@redhat.com>
Setting it to true can cause the device size to be queried from libblkio
in otherwise fast paths, degrading performance. Set it to false and
require users to refresh the device size explicitly instead.
Fixes: 4c8f4fda0504 ("block/blkio: Tolerate device size changes")
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Alberto Faria <afaria@redhat.com>
Message-Id: <20221108144433.1334074-1-afaria@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/blkio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blkio.c b/block/blkio.c
index 620fab28a7..5eae3adfaf 100644
--- a/block/blkio.c
+++ b/block/blkio.c
@@ -993,7 +993,6 @@ static void blkio_refresh_limits(BlockDriverState *bs,
Error **errp)
{ \
.format_name = name, \
.protocol_name = name, \
- .has_variable_length = true, \
.instance_size = sizeof(BDRVBlkioState), \
.bdrv_file_open = blkio_file_open, \
.bdrv_close = blkio_close, \
--
2.38.1
- [PULL 00/11] Block layer patches, Kevin Wolf, 2022/11/11
- [PULL 03/11] block/mirror: Fix NULL s->job in active writes, Kevin Wolf, 2022/11/11
- [PULL 04/11] iotests/151: Test that active mirror progresses, Kevin Wolf, 2022/11/11
- [PULL 02/11] block/mirror: Drop mirror_wait_for_any_operation(), Kevin Wolf, 2022/11/11
- [PULL 01/11] block/mirror: Do not wait for active writes, Kevin Wolf, 2022/11/11
- [PULL 06/11] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description, Kevin Wolf, 2022/11/11
- [PULL 05/11] iotests/151: Test active requests on mirror start, Kevin Wolf, 2022/11/11
- [PULL 07/11] block/blkio: Set BlockDriver::has_variable_length to false,
Kevin Wolf <=
- [PULL 08/11] block: Make bdrv_child_get_parent_aio_context I/O, Kevin Wolf, 2022/11/11
- [PULL 09/11] block-backend: Update ctx immediately after root, Kevin Wolf, 2022/11/11
- [PULL 11/11] tests/stream-under-throttle: New test, Kevin Wolf, 2022/11/11
- [PULL 10/11] block: Start/end drain on correct AioContext, Kevin Wolf, 2022/11/11
- Re: [PULL 00/11] Block layer patches, Stefan Hajnoczi, 2022/11/11