Re: [PULL 00/11] Block layer patches

[Hanna Reitz]

On 11.11.22 20:20, Stefan Hajnoczi wrote:
> On Fri, 11 Nov 2022 at 10:29, Kevin Wolf <kwolf@redhat.com> wrote:
> > The following changes since commit 2ccad61746ca7de5dd3e25146062264387e43bd4:
> >
> >    Merge tag 'pull-tcg-20221109' of https://gitlab.com/rth7680/qemu into 
> > staging (2022-11-09 13:26:45 -0500)
> >
> > are available in the Git repository at:
> >
> >    https://repo.or.cz/qemu/kevin.git tags/for-upstream
> >
> > for you to fetch changes up to b04af371af685c12970ea93027dc6d8bf86265aa:
> >
> >    tests/stream-under-throttle: New test (2022-11-11 13:02:43 +0100)
> >
> > ----------------------------------------------------------------
> > Block layer patches
> >
> > - Fix deadlock in graph modification with iothreads
> > - mirror: Fix non-converging cases for active mirror
> > - qapi: Fix BlockdevOptionsNvmeIoUring @path description
> > - blkio: Set BlockDriver::has_variable_length to false
> >
> > ----------------------------------------------------------------
> > Alberto Faria (2):
> >        qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description
> >        block/blkio: Set BlockDriver::has_variable_length to false
> >
> > Hanna Reitz (9):
> >        block/mirror: Do not wait for active writes
> >        block/mirror: Drop mirror_wait_for_any_operation()
> >        block/mirror: Fix NULL s->job in active writes
> >        iotests/151: Test that active mirror progresses
> >        iotests/151: Test active requests on mirror start
> >        block: Make bdrv_child_get_parent_aio_context I/O
> >        block-backend: Update ctx immediately after root
> >        block: Start/end drain on correct AioContext
> >        tests/stream-under-throttle: New test
> Hi Hanna,
> This test is broken, probably due to the minimum Python version:
> https://gitlab.com/qemu-project/qemu/-/jobs/3311521303

:(

I just took the exception name (asyncio.exceptions.TimeoutError) from 
the test output when a timeout occurred, seems indeed like that’s too 
new.  I’m not entirely sure when that was introduced, and what it’s 
relationship to asyncio.TimeoutError is – in 3.11, the latter is an 
alias for the former, but I have 3.10 myself, where the documentation 
says both are distinct.  Anyway, using either works fine here, and the 
existing scripts in python/qemu use asyncio.TimeoutError, so I’ve sent a 
v2 of the patch to do the same.

(For the record, this test isn’t vital for anything, so just dropping it 
from the pull request seems perfectly fine to me.)

Hanna