On Sat, Nov 5, 2022 at 6:45 PM Michael S. Tsirkin <
mst@redhat.com> wrote:
From: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20221017102146.2254096-2-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
NB: we do not expect any functional change in
any ACPI tables with this change. It's only a refactoring.
Reviewed-by: Ani Sinha <ani@anisinha.ca>
---
hw/display/vga_int.h | 2 ++
hw/display/acpi-vga-stub.c | 7 +++++++
hw/display/acpi-vga.c | 26 ++++++++++++++++++++++++++
hw/display/vga-pci.c | 4 ++++
hw/i386/acpi-build.c | 26 +-------------------------
hw/display/meson.build | 17 +++++++++++++++++
6 files changed, 57 insertions(+), 25 deletions(-)
create mode 100644 hw/display/acpi-vga-stub.c
create mode 100644 hw/display/acpi-vga.c
With this "qemu:qtest+qtest-hppa / qtest-hppa/display-vga-test" fails due to the symbol "aml_return" being undefined:
# starting QEMU: exec ./qemu-system-hppa -qtest unix:/tmp/qtest-515650.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-515650.qmp,id=char0 -mon chardev=char0,mode=control -display none -vga none -device virtio-vga -accel qtest
----------------------------------- stderr -----------------------------------
Failed to open module: qemu/build/qemu-bundle/usr/lib/qemu/hw-display-virtio-vga.so: undefined symbol: aml_return
qemu-system-hppa: -device virtio-vga: 'virtio-vga' is not a valid device model name
Broken pipe
../src/tests/qtest/libqtest.c:179: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0)
(test program exited with status code -6)
Best regards,
Bernhard