[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/12] gdb-xml: Fix size of EFER register on i386 architecture whe
From: |
Paolo Bonzini |
Subject: |
[PULL 04/12] gdb-xml: Fix size of EFER register on i386 architecture when debugged by GDB |
Date: |
Sun, 6 Nov 2022 09:51:07 +0100 |
From: TaiseiIto <taisei1212@outlook.jp>
Before this commit, there were contradictory descriptions about size of EFER
register.
Line 113 says the size is 8 bytes.
Line 129 says the size is 4 bytes.
As a result, when GDB is debugging an OS running on QEMU, the GDB cannot
read 'g' packets correctly. This 'g' packet transmits values of each
registers of machine emulated by QEMU to GDB. QEMU, the packet sender,
assign 4 bytes for EFER in 'g' packet based on the line 113.
GDB, the packet receiver, extract 8 bytes for EFER in 'g' packet based on
the line 129. Therefore, all registers located behind EFER in 'g' packet
has been shifted 4 bytes in GDB.
After this commit, GDB can read 'g' packets correctly.
Signed-off-by: TaiseiIto <taisei1212@outlook.jp>
Message-Id:
<TY0PR0101MB4285F637209075C9F65FCDA6A4479@TY0PR0101MB4285.apcprd01.prod.exchangelabs.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
gdb-xml/i386-32bit.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb-xml/i386-32bit.xml b/gdb-xml/i386-32bit.xml
index 872fcea9c25a..7a66a02b67e3 100644
--- a/gdb-xml/i386-32bit.xml
+++ b/gdb-xml/i386-32bit.xml
@@ -110,7 +110,7 @@
<field name="PKE" start="22" end="22"/>
</flags>
- <flags id="i386_efer" size="8">
+ <flags id="i386_efer" size="4">
<field name="TCE" start="15" end="15"/>
<field name="FFXSR" start="14" end="14"/>
<field name="LMSLE" start="13" end="13"/>
--
2.38.1
- [PULL 00/12] Misc bugfix patches (+ improved module errors) for QEMU 7.2, Paolo Bonzini, 2022/11/06
- [PULL 01/12] util/main-loop: Fix maximum number of wait objects for win32, Paolo Bonzini, 2022/11/06
- [PULL 02/12] util/main-loop: Avoid adding the same HANDLE twice, Paolo Bonzini, 2022/11/06
- [PULL 04/12] gdb-xml: Fix size of EFER register on i386 architecture when debugged by GDB,
Paolo Bonzini <=
- [PULL 03/12] util/aio-win32: Correct the event array size in aio_poll(), Paolo Bonzini, 2022/11/06
- [PULL 05/12] Fix broken configure with -Wunused-parameter, Paolo Bonzini, 2022/11/06
- [PULL 06/12] meson: avoid unused arguments of main() in compiler tests, Paolo Bonzini, 2022/11/06
- [PULL 07/12] Add missing include statement for global xml_builtin, Paolo Bonzini, 2022/11/06
- [PULL 08/12] module: removed unused function argument "mayfail", Paolo Bonzini, 2022/11/06
- [PULL 09/12] module: rename module_load_one to module_load, Paolo Bonzini, 2022/11/06
- [PULL 10/12] module: add Error arguments to module_load and module_load_qom, Paolo Bonzini, 2022/11/06
- [PULL 11/12] dmg: warn when opening dmg images containing blocks of unknown type, Paolo Bonzini, 2022/11/06
- [PULL 12/12] accel: abort if we fail to load the accelerator plugin, Paolo Bonzini, 2022/11/06