qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 07/11] Hexagon (target/hexagon) Add overrides for direct c


From: Richard Henderson
Subject: Re: [PATCH v3 07/11] Hexagon (target/hexagon) Add overrides for direct call instructions
Date: Sat, 5 Nov 2022 11:21:02 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 11/5/22 06:26, Taylor Simpson wrote:
+static void gen_write_new_pc_addr(DisasContext *ctx, TCGv addr, TCGv pred)
+{
+    TCGLabel *pred_false = NULL;
+    if (pred != NULL) {
+        pred_false = gen_new_label();
+        tcg_gen_brcondi_tl(TCG_COND_EQ, pred, 0, pred_false);
+    }

It would be nice to pass down the entire branch condition. Trivial for usage within this patch, but more complex for others.

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]