Re: [PATCH v3] linux-user: implement execveat

[Laurent Vivier]

Le 04/11/2022 à 10:55, Drew DeVault a écrit :
> On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote:
> > Splitting this big patch would ease review:
>
> It's only +165/-131, are you sure it really needs to be split?
>
> > 1/ Replace safe_execve() by safe_execveat()
> >
> >      -safe_execve(exec_path, argp, envp))
> >      +safe_execveat(AT_FDCWD, exec_path, argp, envp, 0));
> >
> > 2/ Extract do_execve()
> >
> > 3/ Convert do_execve() to do_execveat() adding dirfd/flags args
> >
> > 4/ Add TARGET_NR_execveat case

I think it's not needed, it's mainly a code move and it's easy to compare.

Thanks,
Laurent