|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v3] linux-user: implement execveat |
Date: | Fri, 4 Nov 2022 11:01:16 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 |
On 4/11/22 10:55, Drew DeVault wrote:
On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote:Splitting this big patch would ease review:It's only +165/-131, are you sure it really needs to be split?
I tend to ignore patches over 120 lines of change :) In this case it is about execve(), so critical enough to have me spend the time to figure out your changes and decompose them. Think about someone looking at your patch in months and not having to do that decomposition again. Anyway, it is up to the maintainer who will merge your patch ;)
1/ Replace safe_execve() by safe_execveat() -safe_execve(exec_path, argp, envp)) +safe_execveat(AT_FDCWD, exec_path, argp, envp, 0)); 2/ Extract do_execve() 3/ Convert do_execve() to do_execveat() adding dirfd/flags args 4/ Add TARGET_NR_execveat case
[Prev in Thread] | Current Thread | [Next in Thread] |