Re: [PATCH 30/37] target/i386: reimplement 0x0f 0x10-0x17, add AVX

[Richard Henderson]

On 9/14/22 23:45, Paolo Bonzini wrote:
> > You've just been moving i64 pieces in the other functions, why is this one 
> > different using
> > a gvec move in the middle?  I do wonder if a generic helper moving 
> > offset->offset, with
> > the comparison wouldn't be helpful within these functions, even when you know 
> > off1 !=
> > off2, due to Q(0) vs Q(1).
>
> Because this one is the only one that has a VEX.256 version (the
> operand is type "x"
> rather than "dq" as in MOVHLPS, MOVLHPS, MOVHPx).

Ok, then a comment would help.


r~