|
From: | Richard Henderson |
Subject: | Re: [PATCH 31/37] target/i386: reimplement 0x0f 0x28-0x2f, add AVX |
Date: | Tue, 13 Sep 2022 11:24:37 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 9/12/22 00:04, Paolo Bonzini wrote:
+static void decode_0F2B(DisasContext *s, CPUX86State *env, X86OpEntry *entry, uint8_t *b) +{ + static const X86OpEntry opcodes_0F2B[4] = { + X86_OP_ENTRY3(MOVDQ, M,x, None,None, V,x, vex4), /* MOVNTPS */ + X86_OP_ENTRY3(MOVDQ, M,x, None,None, V,x, vex4), /* MOVNTPD */ + X86_OP_ENTRY3(VMOVSS_st, M,ss, None,None, V,x, vex4), + X86_OP_ENTRY3(VMOVLPx_st, M,sd, None,None, V,x, vex4), /* MOVSD */
These last two look wrong. And if you don't have those, you use ENTRY3 instead of GROUP0 in the main table?
r~
[Prev in Thread] | Current Thread | [Next in Thread] |