Re: [PATCH v4] Align Raspberry Pi DMA interrupts with Linux DTS

[Peter Maydell]

On Sat, 16 Jul 2022 at 12:34, Andrey Makarov <ph.makarov@gmail.com> wrote:
>
> There is nothing in the specs on DMA engine interrupt lines: it should have
> been in the "BCM2835 ARM Peripherals" datasheet but the appropriate
> "ARM peripherals interrupt table" (p.113) is nearly empty.
>
> All Raspberry Pi models 1-3 (based on bcm2835) have
> Linux device tree (arch/arm/boot/dts/bcm2835-common.dtsi +25):
>
>     /* dma channel 11-14 share one irq */
>
> This information is repeated in the driver code
> (drivers/dma/bcm2835-dma.c +1344):
>
>     /*
>      * in case of channel >= 11
>      * use the 11th interrupt and that is shared
>      */
>
> In this patch channels 0--10 and 11--14 are handled separately.
>
> Signed-off-by: Andrey Makarov <andrey.makarov@auriga.com>

Thanks; I fixed a couple of scripts/checkpatch.pl nits
(block comments should have /* on line of their own;
open brace of function definitions goes on its own line;
if, for, etc always need {} even for one-line bodies)
and applied it to target-arm.next.

-- PMM