[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] configure, pc-bios/vof: pass cross CFLAGS correctly
From: |
Richard Henderson |
Subject: |
Re: [PATCH 4/6] configure, pc-bios/vof: pass cross CFLAGS correctly |
Date: |
Tue, 21 Jun 2022 08:14:46 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 6/21/22 00:51, Paolo Bonzini wrote:
Use the flags passed to the configure script for the ppc cross compiler,
which in fact default to those that are needed to get the 32-bit ISA.
Add the endianness flag so that it remains possible to use a ppc64le
compiler to compile VOF.
This also fixes compilation of TCG tests using a biarch compiler,
for example ppc64 tests on ppc64le.
Reported-by: Matheus Ferst <matheus.ferst@eldorado.org.br
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Probably you missed this, but last night (gmt-7) I sent:
make[1]: Entering directory `/home/rth/qemu/bld/pc-bios/vof'
cc -m32 -mbig-endian -mcpu=power4 -c -o entry.o
/home/rth/qemu/src/pc-bios/vof/entry.S
cc1: error: ‘-m32’ not supported in this configuration
make[1]: *** [entry.o] Error 1
This with a compiler I built myself,
$ cc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/home/rth/gcc/run/libexec/gcc/powerpc64le-unknown-linux-gnu/11.0.1/lto-wrapper
Target: powerpc64le-unknown-linux-gnu
Configured with: ../git-gcc/configure --prefix=/home/rth/gcc/run
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.0.1 20210321 (experimental) [master revision
19ff0b0:fca73fc:6af7b307f659a4f1845a9efd36ca37899515e234] (GCC)
With default configure options, gcc is not biarch.
It would be good to probe whether EXTRA_CFLAGS is actually usable.
r~
- [PATCH 0/6] Fix support for biarch compilers and cross cflags, Paolo Bonzini, 2022/06/21
- [PATCH 1/6] pc-bios/optionrom: use -m16 unconditionally, Paolo Bonzini, 2022/06/21
- [PATCH 2/6] configure, pc-bios/optionrom: pass cross CFLAGS correctly, Paolo Bonzini, 2022/06/21
- [PATCH 4/6] configure, pc-bios/vof: pass cross CFLAGS correctly, Paolo Bonzini, 2022/06/21
- Re: [PATCH 4/6] configure, pc-bios/vof: pass cross CFLAGS correctly,
Richard Henderson <=
- [PATCH 3/6] configure, pc-bios/s390-ccw: pass cross CFLAGS correctly, Paolo Bonzini, 2022/06/21
- [PATCH 6/6] configure: write EXTRA_CFLAGS for all sub-Makefiles, Paolo Bonzini, 2022/06/21
- [PATCH 5/6] configure: allow more host/target combos to use the host compiler, Paolo Bonzini, 2022/06/21
- Re: [PATCH 0/6] Fix support for biarch compilers and cross cflags, Matheus Kowalczuk Ferst, 2022/06/21