|
From: | Richard Henderson |
Subject: | Re: [PATCH 2/6] configure, pc-bios/optionrom: pass cross CFLAGS correctly |
Date: | Tue, 21 Jun 2022 07:55:44 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 6/21/22 00:51, Paolo Bonzini wrote:
diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile index ea89ce9d59..e90ca2e1c6 100644 --- a/pc-bios/optionrom/Makefile +++ b/pc-bios/optionrom/Makefile @@ -11,7 +11,7 @@ CFLAGS = -O2 -g quiet-command = $(if $(V),$1,$(if $(2),@printf " %-7s %s\n" $2 $3 && $1, @$1)) cc-option = $(if $(shell $(CC) $1 -c -o /dev/null -xc /dev/null >/dev/null 2>&1 && echo OK), $1, $2)-override CFLAGS += -march=i486 -Wall -m16+override CFLAGS += -march=i486 -Wall $(EXTRA_CFLAGS) -m16
Hmm. I'm not sure about this. Given that EXTRA_CFLAGS is going to be e.g. -m32 or empty, being immediately overwritten to -m16, I don't quite see the point.
It seems like there should be a third cross-compiler "i386_m16" or something, with a different set of cflags at the configure level. Overkill?
r~
[Prev in Thread] | Current Thread | [Next in Thread] |