qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 4/7] tests/docker: fix the IMAGE for build invocation


From: Richard Henderson
Subject: Re: [PATCH v1 4/7] tests/docker: fix the IMAGE for build invocation
Date: Mon, 13 Jun 2022 14:47:10 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 6/13/22 10:12, Alex Bennée wrote:
We inadvertently broke the ability to run local builds when the code
was re-factored. The result was the run stanza failing to find the
docker image with it's qemu/ prefix.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Fixes: d39eaa2266 ("tests/docker: simplify docker-TEST@IMAGE targets")
---
  tests/docker/Makefile.include | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index e68f91b853..ef4518d9eb 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -171,7 +171,7 @@ DOCKER_TESTS := $(if $(TESTS), $(filter $(TESTS), 
$(__TESTS)), $(__TESTS))
  $(foreach i,$(filter-out $(DOCKER_PARTIAL_IMAGES),$(DOCKER_IMAGES)), \
        $(foreach t,$(DOCKER_TESTS), \
                $(eval .PHONY: docker-$t@$i) \
-               $(eval docker-$t@$i: docker-image-$i; @$(MAKE) docker-run 
TEST=$t IMAGE=$i) \
+               $(eval docker-$t@$i: docker-image-$i; @$(MAKE) docker-run 
TEST=$t IMAGE=qemu/$i) \
        ) \
        $(foreach t,$(DOCKER_TESTS), \
                $(eval docker-all-tests: docker-$t@$i) \

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]