[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 6/7] gitlab: compare CIRRUS_nn vars against 'null' not ""
From: |
Alex Bennée |
Subject: |
[PATCH v1 6/7] gitlab: compare CIRRUS_nn vars against 'null' not "" |
Date: |
Mon, 13 Jun 2022 18:12:57 +0100 |
From: Daniel P. Berrangé <berrange@redhat.com>
The GitLab variable comparisons don't have shell like semantics where
an unset variable compares equal to empty string. We need to explicitly
test against 'null' to detect an unset variable.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220608160651.248781-1-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
.gitlab-ci.d/base.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml
index f334f3ded7..69b36c148a 100644
--- a/.gitlab-ci.d/base.yml
+++ b/.gitlab-ci.d/base.yml
@@ -13,7 +13,7 @@
#############################################################
# Cirrus jobs can't run unless the creds / target repo are set
- - if: '$QEMU_JOB_CIRRUS && ($CIRRUS_GITHUB_REPO == "" || $CIRRUS_API_TOKEN
== "")'
+ - if: '$QEMU_JOB_CIRRUS && ($CIRRUS_GITHUB_REPO == null ||
$CIRRUS_API_TOKEN == null)'
when: never
# Publishing jobs should only run on the default branch in upstream
--
2.30.2
- [PATCH v1 0/7] testing/next pre-PR (docker, gitlab, tcg), Alex Bennée, 2022/06/13
- [PATCH v1 4/7] tests/docker: fix the IMAGE for build invocation, Alex Bennée, 2022/06/13
- [PATCH v1 6/7] gitlab: compare CIRRUS_nn vars against 'null' not "",
Alex Bennée <=
- [PATCH v1 5/7] tests/tcg: disable xtensa-linux-user again, Alex Bennée, 2022/06/13
- [PATCH v1 7/7] .gitlab: use less aggressive nproc on our aarch64/32 runners, Alex Bennée, 2022/06/13