|
From: | Richard Henderson |
Subject: | Re: [PATCH 4/6] bsd-user/bsd-file.h: Add implementations for read, pread, readv and preadv |
Date: | Tue, 7 Jun 2022 14:45:00 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 6/7/22 13:14, Warner Losh wrote:
+/* read(2) */ +static inline abi_long do_bsd_read(abi_long arg1, abi_long arg2, abi_long arg3)
Why the inline markers? Best to drop them.
+ /* + * File system calls. + */ + case TARGET_FREEBSD_NR_read: /* read(2) */ + ret = do_bsd_read(arg1, arg2, arg3); + break; + + case TARGET_FREEBSD_NR_pread: /* pread(2) */ + ret = do_bsd_pread(cpu_env, arg1, arg2, arg3, arg4, arg5, arg6); + break; + + case TARGET_FREEBSD_NR_readv: /* readv(2) */ + ret = do_bsd_readv(arg1, arg2, arg3); + break;
Missing preadv, which you added above. r~
[Prev in Thread] | Current Thread | [Next in Thread] |