[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/6] bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate
From: |
Warner Losh |
Subject: |
[PATCH 3/6] bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate |
Date: |
Tue, 7 Jun 2022 14:14:37 -0600 |
Add in the tracing and this system call not implemented boilerplate. Do
this by moving the guts of do_freebsd_syscall to freebsd_syscall. Put
the tracing in the wrapper function. Since freebsd_syscall is a
singleton static function, it will almost certainly be inlined. Fix
comments that referred to do_syscall since that was renamed some tie
ago.
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/freebsd/os-syscall.c | 50 ++++++++++++++++++++++++++++++++---
1 file changed, 46 insertions(+), 4 deletions(-)
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index 510307f29d9..334c573739b 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -201,16 +201,58 @@ void unlock_iovec(struct iovec *vec, abi_ulong
target_addr,
}
/*
- * do_syscall() should always have a single exit point at the end so that
- * actions, such as logging of syscall results, can be performed. All errnos
- * that do_syscall() returns must be -TARGET_<errcode>.
+ * All errnos that freebsd_syscall() returns must be -TARGET_<errcode>.
+ */
+static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
+ abi_long arg2, abi_long arg3, abi_long arg4,
+ abi_long arg5, abi_long arg6, abi_long arg7,
+ abi_long arg8)
+{
+ abi_long ret;
+
+ switch (num) {
+ default:
+ gemu_log("qemu: unsupported syscall: %d\n", num);
+ ret = -TARGET_ENOSYS;
+ break;
+ }
+
+ return ret;
+}
+
+/*
+ * do_freebsd_syscall() should always have a single exit point at the end so
+ * that actions, such as logging of syscall results, can be performed. This
+ * as a wrapper around freebsd_syscall() so that actually happens. Since
+ * that is a singleton, modern compilers will inline it anyway...
*/
abi_long do_freebsd_syscall(void *cpu_env, int num, abi_long arg1,
abi_long arg2, abi_long arg3, abi_long arg4,
abi_long arg5, abi_long arg6, abi_long arg7,
abi_long arg8)
{
- return 0;
+ CPUState *cpu = env_cpu(cpu_env);
+ int ret;
+
+#ifdef DEBUG
+ gemu_log("freebsd syscall %d\n", num);
+#endif
+ trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6,
arg7, arg8);
+ if (do_strace) {
+ print_freebsd_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6);
+ }
+
+ ret = freebsd_syscall(cpu_env, num, arg1, arg2, arg3, arg4, arg5, arg6,
+ arg7, arg8);
+#ifdef DEBUG
+ gemu_log(" = %ld\n", ret);
+#endif
+ if (do_strace) {
+ print_freebsd_syscall_ret(num, ret);
+ }
+ trace_guest_user_syscall_ret(cpu, num, ret);
+
+ return ret;
}
void syscall_init(void)
--
2.33.1
- [PATCH 0/6] bsd-user upstreaming: read, write and exit, Warner Losh, 2022/06/07
- [PATCH 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec, Warner Losh, 2022/06/07
- Re: [PATCH 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec, Richard Henderson, 2022/06/07
- Re: [PATCH 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec, Warner Losh, 2022/06/07
- Re: [PATCH 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec, Richard Henderson, 2022/06/07
- Re: [PATCH 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec, Warner Losh, 2022/06/07
- Re: [PATCH 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec, Richard Henderson, 2022/06/07
- Re: [PATCH 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec, Warner Losh, 2022/06/08
[PATCH 3/6] bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate,
Warner Losh <=
[PATCH 1/6] bsd-user/freebsd/os-syscall.c: lock_iovec, Warner Losh, 2022/06/07
[PATCH 5/6] bsd-user/bsd-file.h: Meat of the write system calls, Warner Losh, 2022/06/07
[PATCH 4/6] bsd-user/bsd-file.h: Add implementations for read, pread, readv and preadv, Warner Losh, 2022/06/07