Re: [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/

[Daniel P . Berrangé]

On Mon, Feb 28, 2022 at 11:53:23AM +0400, Marc-André Lureau wrote:
> Hi Paolo
> 
> On Sat, Feb 26, 2022 at 11:38 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> > On 2/24/22 18:04, Marc-André Lureau wrote:
> > > Paolo,
> > >
> > > This patch is ok, but in some (new?) circumstances it fails with freebsd
> > > and reveals that -lutil was missing for kinfo_getproc() in
> > > util/oslib-posix.c. Please add:
> > >
> > > -util_ss.add(when: 'CONFIG_POSIX', if_true: files('oslib-posix.c'))
> > > +util_ss.add(when: 'CONFIG_POSIX', if_true: [files('oslib-posix.c'),
> > util])
> > >
> > > (even better if we made this specific to freebsd I guess, but not
> > > strictly necessary)
> >
> > Looking again at the patch (because indeed it broke CI :)), I'm not sure
> > it's a good idea.  The code seems to be partly taken from other projects
> > and doesn't follow the QEMU coding standards.
> >
> 
> One more reason imho to not have this in the common qemuutil library.
> 
> Apparently, the helper was added in 2008, commit 64b7b7334b ("Put
> Pseudo-TTY in rawmode for char devices") and it is not necessary since
> Solaris 11.4 (see commit 9df8b20d1). I am not sure we need to maintain
> compatibility with Solaris <11.4 (released on Aug 2018) tbh. According to
> wikipedia page, 11.3 is maintained until January 2024. Maybe wait until
> that and drop it?

We only support the current major release, and thue previous major
release for 2 years overlap. If we consider 11.x releases as major,
then 11.3 went out of scope from QEMU's POV in Aug 2020, and thus
we don't need to care about this code.

More generally though, Solaris isn't even a platform we try to
support at all is it ?

We've never had any formal testing on it. Have we seen people filing
bugs mentioning solaris in the last 5 years ? If QEMU works at all,
I suspect it is merely by luck. 

We could try to flush out anyone who cares by putting in a check in
configure to mark Solaris as deprecated in this release. If someone
complains then we can have the discussion about how we get any CI
testing for it going forward.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|