qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/8] meson: drop the .fa library suffix


From: Paolo Bonzini
Subject: Re: [PATCH 4/8] meson: drop the .fa library suffix
Date: Wed, 23 Feb 2022 10:07:59 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/22/22 20:40, marcandre.lureau@redhat.com wrote:

The .fa suffix was a temporary hack introduced in commit
1f0a1d8a51 ("build-sys hack: link with whole .fa archives") when the
build system was mixed between meson & makefiles. It is no longer
needed.

It is still needed to separate internal and system archives, otherwise the oss-fuzz build fails. Meson adds a --start-group/--end-group pair around all libraries, and the fork-fuzz.ld linker script should be outside it. If the libraries are named .a, the --start-group is placed much earlier.

This is of course a very ugly workaround; Meson should just use the objects instead of the archives when link_whole is used with an internal convenience archive.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]