[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/9] user: Declare target-specific prototypes in 'user/cpu-ta
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 7/9] user: Declare target-specific prototypes in 'user/cpu-target.h' |
Date: |
Fri, 11 Feb 2022 10:30:09 +0100 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 |
+Thomas
On 11/2/22 00:19, Richard Henderson wrote:
On 2/10/22 10:00, Philippe Mathieu-Daudé wrote:
Move user-mode specific prototypes from "exec/exec-all.h"
to "user/cpu-target.h".
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
Why a new cpu-target.h, and what is it supposed to mean? What else is
going in there? It all looks cpu_loop related so far.
I'd like to put all declarations using target_ulong in foo-target.h and
the ones which don't in foo-common.h (cpu, user, exec).
That way I can move implementations from target-specific to target
agnostic meson source set, and better isolate the target-specific APIs.
Why is this separate from the next patch, with "cpu-common.h", which
also appears to be basically cpu_loop related?
I can squash both. The commit description could be "Move APIs using
target_ulong to cpu-target.h, keep the rest in cpu-common.h".
- Re: [PATCH 1/9] accel/tcg: Add missing 'tcg/tcg.h' header, (continued)
- [PATCH 2/9] coverity-scan: Cover common-user/, Philippe Mathieu-Daudé, 2022/02/09
- [PATCH 3/9] include: Move exec/user/ to user/, Philippe Mathieu-Daudé, 2022/02/09
- [PATCH 4/9] linux-user/exit: Add missing 'qemu/plugin.h' header, Philippe Mathieu-Daudé, 2022/02/09
- [PATCH 7/9] user: Declare target-specific prototypes in 'user/cpu-target.h', Philippe Mathieu-Daudé, 2022/02/09
- [PATCH 6/9] exec: Define MMUAccessType in 'exec/cpu-tlb.h' header, Philippe Mathieu-Daudé, 2022/02/09
- [PATCH 5/9] linux-user/cpu_loop: Add missing 'exec/cpu-all.h' header, Philippe Mathieu-Daudé, 2022/02/09
- [PATCH 8/9] user: Declare target-agnostic prototypes in 'user/cpu-common.h', Philippe Mathieu-Daudé, 2022/02/09
- [PATCH 9/9] user: Share preexit_cleanup() with linux and bsd implementations, Philippe Mathieu-Daudé, 2022/02/09