Re: [PATCH 9/9] user: Share preexit_cleanup() with linux and bsd implementations

[Richard Henderson]

On 2/10/22 10:00, Philippe Mathieu-Daudé wrote:
> preexit_cleanup() is not Linux specific, move it to common-user/.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   {linux-user => common-user}/exit.c | 0
>   common-user/meson.build            | 1 +
>   linux-user/meson.build             | 1 -
>   3 files changed, 1 insertion(+), 1 deletion(-)
>   rename {linux-user => common-user}/exit.c (100%)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Of course, the next step is to use the function (cc Warner).


r~

> diff --git a/linux-user/exit.c b/common-user/exit.c
> similarity index 100%
> rename from linux-user/exit.c
> rename to common-user/exit.c
> diff --git a/common-user/meson.build b/common-user/meson.build
> index 26212dda5c..7204f8bd61 100644
> --- a/common-user/meson.build
> +++ b/common-user/meson.build
> @@ -1,6 +1,7 @@
>   common_user_inc += include_directories('host/' / host_arch)
>   
>   user_ss.add(files(
> +  'exit.c',
>     'safe-syscall.S',
>     'safe-syscall-error.c',
>   ))
> diff --git a/linux-user/meson.build b/linux-user/meson.build
> index de4320af05..25756a2518 100644
> --- a/linux-user/meson.build
> +++ b/linux-user/meson.build
> @@ -9,7 +9,6 @@ common_user_inc += include_directories('include')
>   
>   linux_user_ss.add(files(
>     'elfload.c',
> -  'exit.c',
>     'fd-trans.c',
>     'linuxload.c',
>     'main.c',