[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] qapi/ui: introduce change-vnc-listen
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 2/2] qapi/ui: introduce change-vnc-listen |
Date: |
Tue, 21 Dec 2021 15:15:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> Add command that can change addresses where VNC server listens for new
> connections. Prior to 6.0 this functionality was available through
> 'change' qmp command which was deleted.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> docs/about/removed-features.rst | 3 ++-
> qapi/ui.json | 12 ++++++++++++
> ui/vnc.c | 26 ++++++++++++++++++++++++++
> 3 files changed, 40 insertions(+), 1 deletion(-)
>
> diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
> index d42c3341de..20e6901a82 100644
> --- a/docs/about/removed-features.rst
> +++ b/docs/about/removed-features.rst
> @@ -348,7 +348,8 @@ documentation of ``query-hotpluggable-cpus`` for
> additional details.
> ``change`` (removed in 6.0)
> '''''''''''''''''''''''''''
>
> -Use ``blockdev-change-medium`` or ``change-vnc-password`` instead.
> +Use ``blockdev-change-medium`` or ``change-vnc-password`` or
> +``change-vnc-listen`` instead.
>
> ``query-events`` (removed in 6.0)
> '''''''''''''''''''''''''''''''''
> diff --git a/qapi/ui.json b/qapi/ui.json
> index d7567ac866..14e6fe0b4c 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -1304,3 +1304,15 @@
> { 'command': 'display-reload',
> 'data': 'DisplayReloadOptions',
> 'boxed' : true }
> +
> +##
> +# @change-vnc-listen:
> +#
> +# Change set of addresses to listen for connections.
Please document the arguments:
# @id: lorem ipsum
#
# @address: dolor sit amet
#
# @websockets: consectetur adipisici elit
> +#
> +# Since: 7.0
> +#
> +##
> +{ 'command': 'change-vnc-listen',
> + 'data': { 'id': 'str', 'addresses': ['SocketAddress'],
> + '*websockets': ['SocketAddress'] } }
Lacks 'if': 'CONFIG_VNC'.
We already have change-vnc-password. You add change-vnc-listen. Is
there anything else we might want to change?
Aside: what's the difference between change-vnc-password and
set_password?
[...]