qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] qapi/ui: introduce change-vnc-listen


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 2/2] qapi/ui: introduce change-vnc-listen
Date: Tue, 21 Dec 2021 16:35:55 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

21.12.2021 11:13, Marc-André Lureau wrote:
Hi

On Mon, Dec 20, 2021 at 10:24 PM Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com 
<mailto:vsementsov@virtuozzo.com>> wrote:

    Add command that can change addresses where VNC server listens for new
    connections. Prior to 6.0 this functionality was available through
    'change' qmp command which was deleted.

    Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com 
<mailto:vsementsov@virtuozzo.com>>


Looks good to me,
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com 
<mailto:marcandre.lureau@redhat.com>>

Could you write an avocado test for it? (tests/avocado/vnc.py)

Thanks a lot for reviewing! I will.


--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]