[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] migration: ram_release_pages() always receive 1 page as
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 3/5] migration: ram_release_pages() always receive 1 page as argument |
|
Date: |
Thu, 16 Dec 2021 10:27:49 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/16/21 10:13, Juan Quintela wrote:
> Remove the pages argument. And s/pages/page/
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/ram.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> -static void ram_release_pages(const char *rbname, uint64_t offset, int pages)
> +static void ram_release_page(const char *rbname, uint64_t offset)
> {
> if (!migrate_release_ram() || !migration_in_postcopy()) {
> return;
> }
>
> - ram_discard_range(rbname, offset, ((ram_addr_t)pages) <<
> TARGET_PAGE_BITS);
> + ram_discard_range(rbname, offset, ((ram_addr_t)1) << TARGET_PAGE_BITS);
1ULL?
Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>