Re: [PATCH 1/5] migration: All this fields are unsigned

[Philippe Mathieu-Daudé]

On 12/16/21 10:13, Juan Quintela wrote:
> So printing it as %d is wrong.  Notice that for the channel id, that
> is an uint8_t, but I changed it anyways for consistency.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/multifd-zlib.c | 20 ++++++++++----------
>  migration/multifd-zstd.c | 24 ++++++++++++------------
>  migration/multifd.c      | 16 ++++++++--------
>  migration/trace-events   | 26 +++++++++++++-------------
>  4 files changed, 43 insertions(+), 43 deletions(-)

>  # multifd.c
> -multifd_new_send_channel_async(uint8_t id) "channel %d"
> -multifd_recv(uint8_t id, uint64_t packet_num, uint32_t used, uint32_t flags, 
> uint32_t next_packet_size) "channel %d packet_num %" PRIu64 " pages %d flags 
> 0x%x next packet size %d"
> -multifd_recv_new_channel(uint8_t id) "channel %d"
> +multifd_new_send_channel_async(uint8_t id) "channel %u"
> +multifd_recv(uint8_t id, uint64_t packet_num, uint32_t used, uint32_t flags, 
> uint32_t next_packet_size) "channel %u packet_num %" PRIu64 " pages %u flags 
> 0x%x next packet size %u"
> +multifd_recv_new_channel(uint8_t id) "channel %u"
>  multifd_recv_sync_main(long packet_num) "packet num %ld"
> -multifd_recv_sync_main_signal(uint8_t id) "channel %d"
> -multifd_recv_sync_main_wait(uint8_t id) "channel %d"
> +multifd_recv_sync_main_signal(uint8_t id) "channel %u"
> +multifd_recv_sync_main_wait(uint8_t id) "channel %u"
>  multifd_recv_terminate_threads(bool error) "error %d"
> -multifd_recv_thread_end(uint8_t id, uint64_t packets, uint64_t pages) 
> "channel %d packets %" PRIu64 " pages %" PRIu64
> -multifd_recv_thread_start(uint8_t id) "%d"
> -multifd_send(uint8_t id, uint64_t packet_num, uint32_t used, uint32_t flags, 
> uint32_t next_packet_size) "channel %d packet_num %" PRIu64 " pages %d flags 
> 0x%x next packet size %d"
> -multifd_send_error(uint8_t id) "channel %d"
> +multifd_recv_thread_end(uint8_t id, uint64_t packets, uint64_t pages) 
> "channel %u packets %" PRIu64 " pages %" PRIu64
> +multifd_recv_thread_start(uint8_t id) "%u"
> +multifd_send(uint8_t id, uint64_t packet_num, uint32_t used, uint32_t flags, 
> uint32_t next_packet_size) "channel %u packet_num %" PRIu64 " pages %u flags 
> 0x%x next packet size %u"
> +multifd_send_error(uint8_t id) "channel %u"
>  multifd_send_sync_main(long packet_num) "packet num %ld"
> -multifd_send_sync_main_signal(uint8_t id) "channel %d"
> -multifd_send_sync_main_wait(uint8_t id) "channel %d"
> +multifd_send_sync_main_signal(uint8_t id) "channel %u"
> +multifd_send_sync_main_wait(uint8_t id) "channel %u"
>  multifd_send_terminate_threads(bool error) "error %d"

Nitpicking: bool is unsigned :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>