qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Move the libssh setup from configure to meson.build


From: Thomas Huth
Subject: Re: [PATCH v2] Move the libssh setup from configure to meson.build
Date: Mon, 13 Dec 2021 08:15:02 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

On 10/12/2021 14.05, Philippe Mathieu-Daudé wrote:
On 12/9/21 16:22, Richard W.M. Jones wrote:
On Thu, Dec 09, 2021 at 04:08:24PM +0100, Thomas Huth wrote:
On 09/12/2021 15.55, Richard W.M. Jones wrote:
On Thu, Dec 09, 2021 at 03:48:01PM +0100, Thomas Huth wrote:
It's easier to do this in meson.build now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  v2: Added the missing "config_host_data.set('CONFIG_LIBSSH', libssh.found())"

  configure                     | 27 ---------------------------
  meson.build                   | 13 +++++++++----
  meson_options.txt             |  2 ++
  scripts/meson-buildoptions.sh |  3 +++
  4 files changed, 14 insertions(+), 31 deletions(-)

I should say that my interest in the ssh driver in qemu is not that
much these days.  I've been telling people to use nbdkit-ssh-plugin
instead.  It's more featureful and running it in a separate process is
probably safer too.

Then it's maybe time to deprecate the ssh driver in QEMU?

Weeeellllll ...  I didn't necessarily want to say that.  Others may be
using it, and deprecating working software causes trouble for some.
But I'll let others have their say on this.

The deprecation process is slow, users have 8 months to notice it,
and we might discover contributors willing to maintain it. IOW more
PROs than CONs IMHO.

Right - one of the ideas of the deprecation process is that this is a way to find out if a feature is still used in practice, and whether someone still cares about it being maintained. So if you think that there is a better alternative these days and don't want to maintain the feature forever anymore, just send a patch to docs/about/deprecated.rst to mark it as deprecated there (and the status in MAINTAINERS should maybe rather be "Odd Fixes" than "Supported", I guess?).

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]