Re: [PATCH v2] Move the libssh setup from configure to meson.build

[Philippe Mathieu-Daudé]

On 12/9/21 16:22, Richard W.M. Jones wrote:
> On Thu, Dec 09, 2021 at 04:08:24PM +0100, Thomas Huth wrote:
>> On 09/12/2021 15.55, Richard W.M. Jones wrote:
>>> On Thu, Dec 09, 2021 at 03:48:01PM +0100, Thomas Huth wrote:
>>>> It's easier to do this in meson.build now.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> ---
>>>>  v2: Added the missing "config_host_data.set('CONFIG_LIBSSH', 
>>>> libssh.found())"
>>>>
>>>>  configure                     | 27 ---------------------------
>>>>  meson.build                   | 13 +++++++++----
>>>>  meson_options.txt             |  2 ++
>>>>  scripts/meson-buildoptions.sh |  3 +++
>>>>  4 files changed, 14 insertions(+), 31 deletions(-)

>>> I should say that my interest in the ssh driver in qemu is not that
>>> much these days.  I've been telling people to use nbdkit-ssh-plugin
>>> instead.  It's more featureful and running it in a separate process is
>>> probably safer too.
>>
>> Then it's maybe time to deprecate the ssh driver in QEMU?
> 
> Weeeellllll ...  I didn't necessarily want to say that.  Others may be
> using it, and deprecating working software causes trouble for some.
> But I'll let others have their say on this.

The deprecation process is slow, users have 8 months to notice it,
and we might discover contributors willing to maintain it. IOW more
PROs than CONs IMHO.

> I will mention that RHEL 9.1 will replace qemu's curl and ssh drivers
> with nbdkit-curl-plugin and nbdkit-ssh-plugin.  For RHEL users this
> should happen transparently.  Libvirt will substitute an external
> nbdkit process when it sees the appropriate <disk> in the XML (all
> RHEL users are required to use libvirt instead of qemu directly).  Of
> course qemu doesn't need to care about what RHEL does, this is just
> for your information.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2016527
> 
> Rich.
>