[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/10] vhost-user-blk: propagate error return from generic vh
|
From: |
Raphael Norwitz |
|
Subject: |
Re: [PATCH 10/10] vhost-user-blk: propagate error return from generic vhost |
|
Date: |
Mon, 29 Nov 2021 22:37:29 +0000 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Ditto - not for 6.2.
I'm happy with this once the vhost and vhost-user patches go in.
Looks like vhost-user-vgpu, vhost-user-input and vhost-user-vsock also
return -1 on vhost_user_*_handle_config_change, so presumably those
should be fixed too.
On Thu, Nov 11, 2021 at 06:33:54PM +0300, Roman Kagan wrote:
> Fix the only callsite that doesn't propagate the error code from the
> generic vhost code.
>
> Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
> ---
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
> hw/block/vhost-user-blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
> index f9b17f6813..ab11ce8252 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -100,7 +100,7 @@ static int vhost_user_blk_handle_config_change(struct
> vhost_dev *dev)
> &local_err);
> if (ret < 0) {
> error_report_err(local_err);
> - return -1;
> + return ret;
> }
>
> /* valid for resize only */
> --
> 2.33.1
>
- [PATCH 05/10] vhost-backend: avoid overflow on memslots_limit, (continued)
[PATCH 07/10] vhost-vdpa: stick to -errno error return convention, Roman Kagan, 2021/11/11
[PATCH 02/10] chardev/char-socket: tcp_chr_recv: don't clobber errno, Roman Kagan, 2021/11/11
[PATCH 09/10] vhost: stick to -errno error return convention, Roman Kagan, 2021/11/11
[PATCH 10/10] vhost-user-blk: propagate error return from generic vhost, Roman Kagan, 2021/11/11
- Re: [PATCH 10/10] vhost-user-blk: propagate error return from generic vhost,
Raphael Norwitz <=
[PATCH 08/10] vhost-user: stick to -errno error return convention, Roman Kagan, 2021/11/11
[PATCH 04/10] chardev/char-fe: don't allow EAGAIN from blocking read, Roman Kagan, 2021/11/11
Re: [PATCH 00/10] vhost: stick to -errno error return convention, Michael S. Tsirkin, 2021/11/11
Re: [PATCH 00/10] vhost: stick to -errno error return convention, Michael S. Tsirkin, 2021/11/28