[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/10] vhost-backend: avoid overflow on memslots_limit
|
From: |
Roman Kagan |
|
Subject: |
[PATCH 05/10] vhost-backend: avoid overflow on memslots_limit |
|
Date: |
Thu, 11 Nov 2021 18:33:49 +0300 |
Fix the (hypothetical) potential problem when the value parsed out of
the vhost module parameter in sysfs overflows the return value from
vhost_kernel_memslots_limit.
Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
---
hw/virtio/vhost-backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c
index b65f8f7e97..44f7dbb243 100644
--- a/hw/virtio/vhost-backend.c
+++ b/hw/virtio/vhost-backend.c
@@ -58,7 +58,7 @@ static int vhost_kernel_memslots_limit(struct vhost_dev *dev)
if (g_file_get_contents("/sys/module/vhost/parameters/max_mem_regions",
&s, NULL, NULL)) {
uint64_t val = g_ascii_strtoull(s, NULL, 10);
- if (!((val == G_MAXUINT64 || !val) && errno)) {
+ if (val < INT_MAX && val > 0) {
g_free(s);
return val;
}
--
2.33.1
- Re: [PATCH 06/10] vhost-backend: stick to -errno error return convention, (continued)
Re: [PATCH 01/10] vhost-user-blk: reconnect on any error during realize, Raphael Norwitz, 2021/11/29
[PATCH 05/10] vhost-backend: avoid overflow on memslots_limit,
Roman Kagan <=
[PATCH 07/10] vhost-vdpa: stick to -errno error return convention, Roman Kagan, 2021/11/11
[PATCH 02/10] chardev/char-socket: tcp_chr_recv: don't clobber errno, Roman Kagan, 2021/11/11
[PATCH 09/10] vhost: stick to -errno error return convention, Roman Kagan, 2021/11/11
[PATCH 10/10] vhost-user-blk: propagate error return from generic vhost, Roman Kagan, 2021/11/11