[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] ui: avoid compiler warnings from unused clipboard info v
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/2] ui: avoid compiler warnings from unused clipboard info variable |
Date: |
Wed, 24 Nov 2021 14:04:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 11/23/21 14:43, Daniel P. Berrangé wrote:
> With latest clang 13.0.0 we get
>
> ../ui/clipboard.c:47:34: error: variable 'old' set but not used
> [-Werror,-Wunused-but-set-variable]
> g_autoptr(QemuClipboardInfo) old = NULL;
> ^
>
> The compiler can't tell that we only declared this variable in
> order to get the side effect of free'ing it when out of scope.
>
> This pattern is a little dubious for a use of g_autoptr, so
> rewrite the code to avoid it.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> ui/clipboard.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>