Re: [PATCH 1/2] ui: avoid compiler warnings from unused clipboard info variable

[Richard Henderson]

On 11/23/21 2:43 PM, Daniel P. Berrangé wrote:
> With latest clang 13.0.0 we get
>
> ../ui/clipboard.c:47:34: error: variable 'old' set but not used 
> [-Werror,-Wunused-but-set-variable]
>      g_autoptr(QemuClipboardInfo) old = NULL;
>                                   ^
>
> The compiler can't tell that we only declared this variable in
> order to get the side effect of free'ing it when out of scope.
>
> This pattern is a little dubious for a use of g_autoptr, so
> rewrite the code to avoid it.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   ui/clipboard.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> diff --git a/ui/clipboard.c b/ui/clipboard.c
> index d7b008d62a..7672058e84 100644
> --- a/ui/clipboard.c
> +++ b/ui/clipboard.c
> @@ -44,12 +44,11 @@ void qemu_clipboard_peer_release(QemuClipboardPeer *peer,
>   
>   void qemu_clipboard_update(QemuClipboardInfo *info)
>   {
> -    g_autoptr(QemuClipboardInfo) old = NULL;
>       assert(info->selection < QEMU_CLIPBOARD_SELECTION__COUNT);
>   
>       notifier_list_notify(&clipboard_notifiers, info);
>   
> -    old = cbinfo[info->selection];
> +    qemu_clipboard_info_unref(cbinfo[info->selection]);
>       cbinfo[info->selection] = qemu_clipboard_info_ref(info);
>   }
>