[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports |
Date: |
Thu, 11 Nov 2021 10:39:59 -0500 |
On Thu, Nov 11, 2021 at 01:09:05PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > When the acpihp driver is used the linux kernel will just call the aml
> > methods and I suspect the pci device will stay invisible then because
> > nobody flips the slot power control bit (with native-hotplug=on, for
> > native-hotplug=off this isn't a problem of course).
>
> Hmm, on a quick smoke test with both patch series (mine + igors) applied
> everything seems to work fine on a quick glance. Dunno why. Maybe the
> pcieport driver turns on slot power even in case pciehp is not active.
Well power and hotplug capabilities are mostly unrelated, right?
> I still feel a bit nervous about trying the new "both pcie + acpi
> hotplug enabled" approach that close to the release date ...
>
> take care,
> Gerd
I feel switching to native so late would be inappropriate, looks more
like a feature than a bugfix. Given that - we need Igor's patches.
Given that - would you say I should apply yours? I'm inclined to
do so but if you prefer waiting until after the release I'll
defer to your judgement.
--
MST
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Michael S. Tsirkin, 2021/11/01
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Michael S. Tsirkin, 2021/11/10
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Gerd Hoffmann, 2021/11/11
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Michael S. Tsirkin, 2021/11/11
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Gerd Hoffmann, 2021/11/11
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Gerd Hoffmann, 2021/11/11
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports,
Michael S. Tsirkin <=
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Gerd Hoffmann, 2021/11/12
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Igor Mammedov, 2021/11/12
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Michael S. Tsirkin, 2021/11/15
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Daniel P . Berrangé, 2021/11/11
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Michael S. Tsirkin, 2021/11/11
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Daniel P . Berrangé, 2021/11/11
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Michael S. Tsirkin, 2021/11/11
- Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports, Gerd Hoffmann, 2021/11/12