|
From: | Richard Henderson |
Subject: | Re: [PATCH] device_tree: Fix compiler error |
Date: | Tue, 9 Nov 2021 09:38:58 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 11/8/21 9:07 PM, Stefan Weil wrote:
A build with gcc (Debian 10.2.1-6) 10.2.1 20210110 fails: ../../../softmmu/device_tree.c: In function ‘qemu_fdt_add_path’: ../../../softmmu/device_tree.c:560:18: error: ‘retval’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 560 | int namelen, retval; | ^~~~~~ This is not a real error, but the compiler can be satisfied with a small change. Fixes: b863f0b75852 ("device_tree: Add qemu_fdt_add_path") Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Though I think there's a good deal that could be cleaned up about this function: (1a) Remove the unused return value? The single use does not check the return. (1b) Don't attempt to return a node, merely a success/failure code. Certainly the local documentation here could be improved... (1c) Return parent; make retval local to the loop. (2) Merge p and path; there's no point retaining the unmodified parameter. (3) Move name and namelen inside the loop. r~
[Prev in Thread] | Current Thread | [Next in Thread] |