Re: [PATCH v3 2/2] accel/tcg: Register a force_rcu notifier

[Richard Henderson]

On 11/9/21 8:54 AM, Richard Henderson wrote:
> On 11/8/21 12:33 PM, Greg Kurz wrote:
> > +static void rr_force_rcu(Notifier *notify, void *data)
> > +{
> > +    /*
> > +     * Called with rcu_registry_lock held, using async_run_on_cpu() ensures
> > +     * that there are no deadlocks.
> > +     */
> > +    async_run_on_cpu(first_cpu, do_nothing, RUN_ON_CPU_NULL);
> > +}
>
> Should first_cpu really be rr_current_cpu?
> It's not clear to me that this will work for -smp 2 -cpu thread=single.

Alternately, no async_run_on_cpu at all, just rr_kick_next_cpu().


r~