Re: [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow
Date:	Sat, 25 Sep 2021 12:55:56 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 9/22/21 06:56, Warner Losh wrote:

mmap should return ENOMEM on len overflow rather than EINVAL. Return
EINVAL when len == 0 and ENOMEM when the rounded to a page length is 0.
Found by make check-tcg.

Signed-off-by: Warner Losh <imp@bsdimp.com>
---
  bsd-user/mmap.c | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 3/9] bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs, (continued)
- [PATCH v2 3/9] bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs, Warner Losh, 2021/09/22
  - Re: [PATCH v2 3/9] bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs, Richard Henderson, 2021/09/24
- [PATCH v2 1/9] bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag(), Warner Losh, 2021/09/22
  - Re: [PATCH v2 1/9] bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag(), Richard Henderson, 2021/09/24
- [PATCH v2 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE, Warner Losh, 2021/09/22
  - Re: [PATCH v2 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE, Richard Henderson, 2021/09/24
    - Re: [PATCH v2 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE, Warner Losh, 2021/09/24
  - Re: [PATCH v2 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE, Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow, Warner Losh, 2021/09/22
  - Re: [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow, Richard Henderson, 2021/09/24
  - Re: [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow, Philippe Mathieu-Daudé <=
- [PATCH v2 6/9] bsd-user/mmap.c: line wrap change, Warner Losh, 2021/09/22
  - Re: [PATCH v2 6/9] bsd-user/mmap.c: line wrap change, Richard Henderson, 2021/09/24
    - Re: [PATCH v2 6/9] bsd-user/mmap.c: line wrap change, Warner Losh, 2021/09/26
- [PATCH v2 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head, Warner Losh, 2021/09/22
  - Re: [PATCH v2 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head, Richard Henderson, 2021/09/24
    - Re: [PATCH v2 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head, Warner Losh, 2021/09/26
- [PATCH v2 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD, Warner Losh, 2021/09/22
  - Re: [PATCH v2 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD, Richard Henderson, 2021/09/24
- [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Warner Losh, 2021/09/22
  - Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Richard Henderson, 2021/09/24

Prev by Date: Re: [PATCH v2 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE
Next by Date: Re: [PATCH v2 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail
Previous by thread: Re: [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow
Next by thread: [PATCH v2 6/9] bsd-user/mmap.c: line wrap change
Index(es):
- Date
- Thread