Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently fr

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently fr

From:	Richard Henderson
Subject:	Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag
Date:	Thu, 23 Sep 2021 10:43:13 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/21/21 9:56 PM, Warner Losh wrote:

          /* no page was there, so we allocate one */
          void *p = mmap(host_start, qemu_host_page_size, prot,
-                       flags | MAP_ANON, -1, 0);
+                       flags | ((fd != -1) ? MAP_ANON : 0), -1, 0);


I don't understand this change, given that the actual fd passed is always -1.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow, (continued)
- [PATCH v2 6/9] bsd-user/mmap.c: line wrap change, Warner Losh, 2021/09/22
  - Re: [PATCH v2 6/9] bsd-user/mmap.c: line wrap change, Richard Henderson, 2021/09/24
    - Re: [PATCH v2 6/9] bsd-user/mmap.c: line wrap change, Warner Losh, 2021/09/26
- [PATCH v2 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head, Warner Losh, 2021/09/22
  - Re: [PATCH v2 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head, Richard Henderson, 2021/09/24
    - Re: [PATCH v2 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head, Warner Losh, 2021/09/26
- [PATCH v2 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD, Warner Losh, 2021/09/22
  - Re: [PATCH v2 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD, Richard Henderson, 2021/09/24
- [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Warner Losh, 2021/09/22
  - Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Richard Henderson <=
    - Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Warner Losh, 2021/09/26
    - Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Guy Yur, 2021/09/26
    - Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Warner Losh, 2021/09/26
- [PATCH v2 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail, Warner Losh, 2021/09/22
  - Re: [PATCH v2 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail, Richard Henderson, 2021/09/24
  - Re: [PATCH v2 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail, Philippe Mathieu-Daudé, 2021/09/25

Prev by Date: Re: [PATCH v2 6/9] bsd-user/mmap.c: line wrap change
Next by Date: Re: [PATCH v2 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head
Previous by thread: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag
Next by thread: Re: [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag
Index(es):
- Date
- Thread