Re: [PATCH 06/10] aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash

[Cédric Le Goater]

On 9/7/21 9:20 AM, Philippe Mathieu-Daudé wrote:
> On 9/7/21 8:58 AM, Cédric Le Goater wrote:
>> It's only useful to compute the initial size of the boot_rom region.
> 
> "AspeedSMCFlash::size is only used to compute the initial size
>  of the boot_rom region. Not very useful, so directly call
>  memory_region_size() instead."?

Sure. I will rephrase.

Thanks,

C. 


> 
>> Use memory_region_size() instead.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>>  include/hw/ssi/aspeed_smc.h | 1 -
>>  hw/arm/aspeed.c             | 7 ++++---
>>  hw/ssi/aspeed_smc.c         | 5 ++---
>>  3 files changed, 6 insertions(+), 7 deletions(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>