[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/10] aspeed/smc: Remove the 'size' attribute from AspeedSMC
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 06/10] aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash |
|
Date: |
Tue, 7 Sep 2021 09:20:34 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 9/7/21 8:58 AM, Cédric Le Goater wrote:
> It's only useful to compute the initial size of the boot_rom region.
"AspeedSMCFlash::size is only used to compute the initial size
of the boot_rom region. Not very useful, so directly call
memory_region_size() instead."?
> Use memory_region_size() instead.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> include/hw/ssi/aspeed_smc.h | 1 -
> hw/arm/aspeed.c | 7 ++++---
> hw/ssi/aspeed_smc.c | 5 ++---
> 3 files changed, 6 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 00/10] aspeed/smc: Cleanups and QOMification, Cédric Le Goater, 2021/09/07
- [PATCH 06/10] aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash, Cédric Le Goater, 2021/09/07
- Re: [PATCH 06/10] aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash,
Philippe Mathieu-Daudé <=
- [PATCH 01/10] aspeed/smc: Add watchdog Control/Status Registers, Cédric Le Goater, 2021/09/07
- [PATCH 07/10] aspeed/smc: Rename AspeedSMCFlash 'id' to 'cs', Cédric Le Goater, 2021/09/07
- [PATCH 08/10] aspeed/smc: QOMify AspeedSMCFlash, Cédric Le Goater, 2021/09/07
- [PATCH 02/10] aspeed/smc: Introduce aspeed_smc_error() helper, Cédric Le Goater, 2021/09/07
- [PATCH 03/10] aspeed/smc: Stop using the model name for the memory regions, Cédric Le Goater, 2021/09/07