Re: [PATCH v2 02/19] host-utils: move abs64() to host-utils as uabs64()

[Eduardo Habkost]

On Tue, Aug 31, 2021 at 01:39:50PM -0300, Luis Pires wrote:
> Move abs64 to host-utils as uabs64, so it can be used elsewhere.
> The function was renamed to uabs64 and modified to return an
> unsigned value. This avoids the undefined behavior for common
> abs implementations, where abs of the most negative value is
> undefined.
> 
> Signed-off-by: Luis Pires <luis.pires@eldorado.org.br>

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

In case you need to send a new version of the series, I'd suggest
separating this into two patches: creation of the uabs64()
function in host-utils, and then changing the KVM PIT code to use
the new uabs64() function.  This way, the rest of your series
won't depend on the KVM PIT changes, helping bisectability and
backportability.

-- 
Eduardo