|
From: | Richard Henderson |
Subject: | Re: [PATCH v2 09/19] target/ppc: Implement DCFFIXQQ |
Date: | Tue, 31 Aug 2021 11:18:27 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/31/21 9:39 AM, Luis Pires wrote:
+DEF_HELPER_3(DCFFIXQQ, void, env, fprp, avr)
Shouldn't be upcase. None of the others are.
diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 5489b4b6e0..c3739f7370 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7422,7 +7422,12 @@ static inline void set_avr64(int regno, TCGv_i64 src, bool high) /* * Helpers for decodetree used by !function for decoding arguments. */ -static int times_4(DisasContext *ctx, int x) +static inline int times_2(DisasContext *ctx, int x) +{ + return x * 2; +} + +static inline int times_4(DisasContext *ctx, int x)
Don't add the inlines.The compiler will decide for itself, and this hides unused function errors under gcc that are diagnosed by clang.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |