Re: [RFC PATCH v2 3/8] failover: virtio-net: remove failover_primary_hidden flag

[Juan Quintela]

Laurent Vivier <lvivier@redhat.com> wrote:
> We dont't need a flag to know if the primary device must be hidden, we
> can rely on the machine state:
> Device is hidden if the machine is in prelaunch state (src) or
> in inmigrate state with migration status set to none (dst).
> We don't need to check the flag in virtio_net_handle_migration_primary()
> because this function is only registered if the failover is enabled
> and the flag also set to false. This function also sets it back to
> true after a successful unplug during the migration but we don't
> need to know it is hidden because nothing will try to plug it back
> after the migration (except in case of error but the flag is set
> back to false).
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>


Much clear.  I was removing all the global failover variables, but
didn't finish the job.

Well done.