|
From: | Juan Quintela |
Subject: | Re: [RFC PATCH v2 2/8] qdev/qbus: remove failover specific code |
Date: | Wed, 25 Aug 2021 17:07:46 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Laurent Vivier <lvivier@redhat.com> wrote: > Commit f3a850565693 ("qdev/qbus: add hidden device support") has > introduced a generic way to hide a device but it has modified > qdev_device_add() to check a specific option of the failover device, > "failover_pair_id", before calling the generic mechanism. > > It's not needed (and not generic) to do that in qdev_device_add() because > this is also checked by the failover_hide_primary_device() function that > uses the generic mechanism to hide the device. > > Cc: Jens Freimann <jfreimann@redhat.com> > Signed-off-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> I see why you want this change. It was done the other way to make sure that we only tried to hide the divec is there is a failover_pair_id property. You can't have both.
[Prev in Thread] | Current Thread | [Next in Thread] |