[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/16] tcg/mips: Move TCG_GUEST_BASE_REG to S7
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 05/16] tcg/mips: Move TCG_GUEST_BASE_REG to S7 |
|
Date: |
Thu, 19 Aug 2021 00:11:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/18/21 10:19 PM, Richard Henderson wrote:
> No functional change; just moving the saved reserved regs to the end.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/mips/tcg-target.c.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/mips/tcg-target.c.inc b/tcg/mips/tcg-target.c.inc
> index 92bde50704..b3a2cc88ab 100644
> --- a/tcg/mips/tcg-target.c.inc
> +++ b/tcg/mips/tcg-target.c.inc
> @@ -86,7 +86,7 @@ static const char * const
> tcg_target_reg_names[TCG_TARGET_NB_REGS] = {
> #define TCG_TMP3 TCG_REG_T7
>
> #ifndef CONFIG_SOFTMMU
> -#define TCG_GUEST_BASE_REG TCG_REG_S1
> +#define TCG_GUEST_BASE_REG TCG_REG_S7
> #endif
Maybe add a comment in tcg_target_callee_save_regs[]?
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v3 00/16] tcg/mips: Unaligned access and other cleanup, Richard Henderson, 2021/08/18
- [PATCH v3 01/16] tcg/mips: Support unaligned access for user-only, Richard Henderson, 2021/08/18
- [PATCH v3 02/16] tcg/mips: Support unaligned access for softmmu, Richard Henderson, 2021/08/18
- [PATCH v3 06/16] tcg/mips: Unify TCG_GUEST_BASE_REG tests, Richard Henderson, 2021/08/18
- [PATCH v3 08/16] tcg/mips: Unset TCG_TARGET_HAS_direct_jump, Richard Henderson, 2021/08/18
- [PATCH v3 04/16] tcg/mips: Move TCG_AREG0 to S8, Richard Henderson, 2021/08/18
- [PATCH v3 07/16] tcg/mips: Allow JAL to be out of range in tcg_out_bswap_subr, Richard Henderson, 2021/08/18
- [PATCH v3 05/16] tcg/mips: Move TCG_GUEST_BASE_REG to S7, Richard Henderson, 2021/08/18
- Re: [PATCH v3 05/16] tcg/mips: Move TCG_GUEST_BASE_REG to S7,
Philippe Mathieu-Daudé <=
- [PATCH v3 11/16] tcg/mips: Split out tcg_out_movi_one, Richard Henderson, 2021/08/18
- [PATCH v3 03/16] tcg/mips: Drop inline markers, Richard Henderson, 2021/08/18
- [PATCH v3 09/16] tcg/mips: Drop special alignment for code_gen_buffer, Richard Henderson, 2021/08/18
- [PATCH v3 10/16] tcg/mips: Create and use TCG_REG_TB, Richard Henderson, 2021/08/18
- [PATCH v3 15/16] tcg/mips: Try tb-relative addresses in tcg_out_movi, Richard Henderson, 2021/08/18
- [PATCH v3 12/16] tcg/mips: Split out tcg_out_movi_two, Richard Henderson, 2021/08/18
- [PATCH v3 14/16] tcg/mips: Aggressively use the constant pool for n64 calls, Richard Henderson, 2021/08/18
- [PATCH v3 13/16] tcg/mips: Use the constant pool for 64-bit constants, Richard Henderson, 2021/08/18