[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/14] tcg/arm: Standardize on tcg_out_<branch>_{reg,imm}
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 02/14] tcg/arm: Standardize on tcg_out_<branch>_{reg,imm} |
|
Date: |
Wed, 18 Aug 2021 23:58:48 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/18/21 11:29 PM, Richard Henderson wrote:
> Some of the functions specified _reg, some _imm, and some
> left it blank. Make it clearer to which we are referring.
>
> Split tcg_out_b_reg from tcg_out_bx_reg, to indicate when
> we do not actually require BX semantics.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/arm/tcg-target.c.inc | 38 ++++++++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 16 deletions(-)
Appreciated cleanup :)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v3 04/14] tcg/arm: Support armv4t in tcg_out_goto and tcg_out_call, (continued)
- [PATCH v3 04/14] tcg/arm: Support armv4t in tcg_out_goto and tcg_out_call, Richard Henderson, 2021/08/18
- [PATCH v3 05/14] tcg/arm: Examine QEMU_TCG_DEBUG environment variable, Richard Henderson, 2021/08/18
- [PATCH v3 06/14] tcg/arm: Support unaligned access for softmmu, Richard Henderson, 2021/08/18
- [PATCH v3 07/14] tcg/arm: Split out tcg_out_ldstm, Richard Henderson, 2021/08/18
- [PATCH v3 02/14] tcg/arm: Standardize on tcg_out_<branch>_{reg,imm}, Richard Henderson, 2021/08/18
- [PATCH v3 08/14] tcg/arm: Simplify usage of encode_imm, Richard Henderson, 2021/08/18
- [PATCH v3 09/14] tcg/arm: Drop inline markers, Richard Henderson, 2021/08/18
- [PATCH v3 10/14] tcg/arm: Give enum arm_cond_code_e a typedef and use it, Richard Henderson, 2021/08/18
- [PATCH v3 13/14] tcg/arm: Reserve a register for guest_base, Richard Henderson, 2021/08/18