|
From: | Mark Cave-Ayland |
Subject: | Re: [PATCH 1/2] gitlab: exclude sparc-softmmu and riscv32-softmmu from cross builds |
Date: | Wed, 18 Aug 2021 10:15:47 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 10/08/2021 15:06, Daniel P. Berrangé wrote:
We need to cut down compile time by excluding more targets. Both these targets still have their 64-bit variant enabled, so the loss of coverage is mitigated to some degree. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- .gitlab-ci.d/crossbuild-template.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/crossbuild-template.yml b/.gitlab-ci.d/crossbuild-template.yml index 7d3ad00a1e..cfb576b54c 100644 --- a/.gitlab-ci.d/crossbuild-template.yml +++ b/.gitlab-ci.d/crossbuild-template.yml @@ -9,7 +9,8 @@ ../configure --enable-werror --disable-docs $QEMU_CONFIGURE_OPTS --disable-user --target-list-exclude="arm-softmmu cris-softmmu i386-softmmu microblaze-softmmu mips-softmmu mipsel-softmmu - mips64-softmmu ppc-softmmu sh4-softmmu xtensa-softmmu" + mips64-softmmu ppc-softmmu riscv32-softmmu sh4-softmmu + sparc-softmmu xtensa-softmmu" - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS - if grep -q "EXESUF=.exe" config-host.mak; then make installer;
I'd prefer to keep sparc-softmmu if possible, simply because my everyday platform is Linux and so having a cross-build for Windows will catch things that I may miss on a day-to-day basis. Is sparc-softmmu currently enabled as part of the native MINGW64 build?
If I go to my Gitlab QEMU fork Settings -> CI/CD -> Variables there is an option to set variables that can be used in job scripts. Perhaps this could be used so that I can configure my personal QEMU fork to always run sparc-softmmu builds when preparing PRs even if they aren't enabled for everyone by default? At least this would then allow me to spot any breakage before sending a final PR to Peter.
ATB, Mark.
[Prev in Thread] | Current Thread | [Next in Thread] |