qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for 6.2 26/49] bsd-user: Create target specific vmparam.h


From: Warner Losh
Subject: Re: [PATCH for 6.2 26/49] bsd-user: Create target specific vmparam.h
Date: Mon, 9 Aug 2021 20:44:19 -0600



On Mon, Aug 9, 2021 at 2:39 PM Richard Henderson <richard.henderson@linaro.org> wrote:
On 8/7/21 11:42 AM, Warner Losh wrote:
> +#define TARGET_MAXTSIZ  (128UL*1024*1024)   /* max text size */
> +#define TARGET_DFLDSIZ  (128UL*1024*1024)   /* initial data size limit */
> +#define TARGET_MAXDSIZ  (512UL*1024*1024)   /* max data size */
> +#define TARGET_DFLSSIZ  (8UL*1024*1024)     /* initial stack size limit */
> +#define TARGET_MAXSSIZ  (64UL*1024*1024)    /* max stack size */
> +#define TARGET_SGROWSIZ (128UL*1024)        /* amount to grow stack */

To-do list: KiB and MiB from units.h.

Easy enough to do now and merge to our main branch
 
> +++ b/bsd-user/qemu.h
> @@ -44,7 +44,7 @@ extern enum BSDType bsd_type;
>   #include "target_arch.h"
>   #include "syscall_defs.h"
>   #include "target_syscall.h"
> -//#include "target_os_vmparam.h"
> +#include "target_os_vmparam.h"
>   //#include "target_os_signal.h"
>   //#include "hostdep.h"

Ah, I see.  Well, perhaps just squash the addition of the include to the patch that
introduces the include?

Good idea.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

thanks!

Warner 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]