Re: [PATCH for 6.2 25/49] bsd-user: define max args in terms of pages

[Warner Losh]

On Mon, Aug 9, 2021 at 2:33 PM Richard Henderson <richard.henderson@linaro.org> wrote:

On 8/7/21 11:42 AM, Warner Losh wrote:
> From: Warner Losh <imp@FreeBSD.org>
>
> For 32-bit platforms, pass in up to 256k of args. For 64-bit, bump that
> to 512k.
>
> Signed-off-by: Kyle Evans <kevans@freebsd.org>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
>   bsd-user/qemu.h | 14 ++++++++++----
>   1 file changed, 10 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> +#define TARGET_ARG_MAX (512 * 1024)
> +#else
> +#define TARGET_ARG_MAX (256 * 1024)

For the to-do list: qemu/units.h has KiB for clarity.

OK. Will change. Thanks!

Warner