[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 12/16] qemu-iotests: allow valgrind to read/delete the generat
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v9 12/16] qemu-iotests: allow valgrind to read/delete the generated log file |
Date: |
Mon, 9 Aug 2021 11:01:10 +0200 |
When using -valgrind on the script tests, it generates a log file
in $TEST_DIR that is either read (if valgrind finds problems) or
otherwise deleted. Provide the same exact behavior when using
-valgrind on the python tests.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/iotests.py | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 26c580f9e7..85d8c0abbb 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -598,6 +598,17 @@ def __init__(self, path_suffix=''):
sock_dir=sock_dir, qmp_timer=timer)
self._num_drives = 0
+ def _post_shutdown(self) -> None:
+ super()._post_shutdown()
+ if not qemu_valgrind or not self._popen:
+ return
+ valgrind_filename = f"{test_dir}/{self._popen.pid}.valgrind"
+ if self.exitcode() == 99:
+ with open(valgrind_filename) as f:
+ print(f.read())
+ else:
+ os.remove(valgrind_filename)
+
def add_object(self, opts):
self._args.append('-object')
self._args.append(opts)
--
2.31.1
- [PATCH v9 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine, (continued)
- [PATCH v9 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 02/16] python: Reduce strictness of pylint's duplicate-code check, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 05/16] qemu-iotests: add option to attach gdbserver, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 06/16] qemu-iotests: delay QMP socket timers, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 08/16] qemu-iotests: add gdbserver option to script tests too, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 11/16] qemu-iotests: extend QMP socket timeout when using valgrind, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 12/16] qemu-iotests: allow valgrind to read/delete the generated log file,
Emanuele Giuseppe Esposito <=
- [PATCH v9 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 15/16] qemu-iotests: add option to show qemu binary logs on stdout, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/08/09
- Re: [PATCH v9 00/16] qemu_iotests: improve debugging options, Hanna Reitz, 2021/08/10